validate_required_attributes was not handling well false values

CHANGELOG.md

@@ -1,3 +1,7 @@
+# 1.0.3
+
+- another fix on `validate_required_attributes` not handling well `false` values
+
 # 1.0.2
 
 - @seb3s fixed a bug, that make `validate_required_attributes` not raising with some

lib/phx_component_helpers.ex

@@ -128,7 +128,7 @@ defmodule PhxComponentHelpers do
   def validate_required_attributes(assigns, nil), do: assigns
 
   def validate_required_attributes(assigns, required) do
-    missing = for attr <- required, !Map.get(assigns, attr), do: attr
+    missing = for attr <- required, is_nil(Map.get(assigns, attr)), do: attr
 
     if Enum.any?(missing) do
       raise ArgumentError, "missing required attributes #{inspect(missing)}"

mix.exs

@@ -4,7 +4,7 @@ defmodule PhxComponentHelpers.MixProject do
   def project do
     [
       app: :phx_component_helpers,
-      version: "1.0.2",
+      version: "1.0.3",
       elixir: "~> 1.7",
       start_permanent: Mix.env() == :prod,
       deps: deps(),

test/phx_component_helpers_test.exs

@@ -54,6 +54,12 @@ defmodule PhxComponentHelpersTest do
       end
     end
 
+    test "with required attributes filled with false, it shoud not raise" do
+      assigns = assigns(%{foo: "foo", bar: "bar"})
+
+      Helpers.set_attributes(assigns, [baz: false], required: [:baz])
+    end
+
     test "with into option, it merges all in a single assign" do
       assigns = assigns(%{foo: "foo", bar: "bar"})