Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add canopydb to the benchmarks #961

Closed
wants to merge 1 commit into from

Conversation

arthurprs
Copy link

@arthurprs arthurprs commented Mar 16, 2025

Adding Canopydb to the benchmarks. I had this for a while but realized I never opened a PR.

Other additional changes

  • Make a lot of values module-level constants
  • Use a sync barrier in multi-threaded sections to reduce variance
  • Use rng fill functions whenever possible
  • Add some basic configuration to Rocksdb. These should be closer to Fjall defaults, for example.
  • Instantiate an env_logger instance. This is a noop in practice, but helps development.

@cberner
Copy link
Owner

cberner commented Mar 16, 2025

canopy looks a bit immature, so I don't want to add it now. Feel free to re-open when it's more widely used and mature.

Those other changes sound reasonable though, if you'd like to send just those, I can review them

@arthurprs
Copy link
Author

That's fair. I'll close this one for now and will follow up with a subset in another PR.

@arthurprs arthurprs closed this Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants