Support for input in freestyle format #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, I wasn't aware of that test body re-use feature - I might take a look at that one day if I'm feeling enthusiastic. Otherwise this looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the patch from #3 and adds tests and documentation. @j4james you might want to take a look at it.
One thing the patch does not do, is support blocks that start with an input section. The semantics for this, in the traditional format, is to re-use the previous tests' test body (and just run it again with different input.) Implementing this with freestyle format probably means adding an extra test somewhere else in the code where it handles this case, but instead of looking for that place and doing that, I just left that combination as unsupported for now (it's not a huge burden, usually; you can just copy and paste test bodies multiple times in your document instead; and it can be always be added later.)