Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: match syntax highlighting tokens to style guide #435

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: match syntax highlighting tokens to style guide #435

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/catppuccin-vsc/src/theme/tokens/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export default function tokens(context: ThemeContext): TextmateColors {
name: "Comments",
scope: ["comment", "punctuation.definition.comment"],
settings: {
foreground: palette.overlay0,
foreground: palette.overlay2,
fontStyle: options.italicComments ? "italic" : "",
},
},
Expand Down Expand Up @@ -107,7 +107,7 @@ export default function tokens(context: ThemeContext): TextmateColors {
},
},
{
name: "Punctuation",
name: "Operators",
scope: [
"keyword.operator",
"punctuation.accessor",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This says punctuation but keyword.operator is not punctuation (=, ==, !, etc) and the punctuation.accessor scope is like ? in TypeScript. We could split them off? I'm not sure what the rest here do...

Expand All @@ -117,7 +117,7 @@ export default function tokens(context: ThemeContext): TextmateColors {
"punctuation.separator.key-value",
],
settings: {
foreground: palette.teal,
foreground: palette.sky,
},
},
{
Expand Down