refactor: use whiskers #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uncenter
commented
Jun 20, 2024
| --ctp-frappe-surface0: #414559; | ||
| --ctp-frappe-base: #303446; | ||
| --ctp-frappe-mantle: #292c3c; | ||
| --ctp-frappe-crust: #232634; |
There was a problem hiding this comment.
I've opted to go with removing the variables entirely and using Whiskers variables below instead as it accomplishes the same thing in a less verbose way (though it does make the diff more complicated).
uncenter
commented
Jun 20, 2024
Comment on lines
+256
to
+263
| pre, .hljs { | ||
| background-color: #F8F8F8 !important; | ||
| font-family: var(--font-mono) !important; | ||
| padding: 10px !important; | ||
| color: {{ crust.hex }} !important; | ||
| font-size: 14px !important; | ||
| overflow: scroll !important; | ||
| } |
There was a problem hiding this comment.
Looks like Joplin uses Highlight.js, which we have a port for... 🤔 could be worth importing in here?
There was a problem hiding this comment.
Feel free to do it, but this might require major refactoring. We can't use imported libraries in Joplin usercss iirc so you'd end up hard coding most of the stuff.
There was a problem hiding this comment.
We can curl it in at build time, save for a later pr. Other than that does this PR look fine?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Whiskers, Catppuccin's in-house templating tool, to build the themes. Instead editing the
.cssfiles individually, edit the.teratemplate files intemplates/and then runjust buildto build the output themes. You will need Whiskers (linked above) and Just installed.