fix: trying to make theme work universally

[nullishamy]

Might close #258

Honestly at this point I don't even know what's happening.

GTK3 doesn't like it when you use -dark on dark themes, you must use -Dark for it to apply properly.
This does not apply to GTK4.

[sgoudham]

Assuming this will work fine on my system but can we please add some documentation in our README.md surrounding this?

This is probably like our 7th time changing it and it's just because knowledge isn't being shared from contributor to contributor and/or written down. I think we finally have a good idea of what is happening on different GTK versions now as we've stopped relying so heavily on Colloid.

[nullishamy]

I have no idea the semantics are for this

[sgoudham]

Honestly this is a good start:

GTK3 doesn't like it when you use -dark on dark themes, you must use -Dark for it to apply properly.
This does not apply to GTK4.

We need to start documenting and accumulating knowledge on it because of how odd it is. People might see that and offer up more info.

[nullishamy]

I'd rather just wait and find out from the GTK people what's going on, opened an issue over there @ https://gitlab.gnome.org/GNOME/gtk/-/issues/6741

[sgoudham]

My testing on Pop!_OS 22.04 LTS on GNOME version 42.9 on X11:

-Dark: this suffix correctly themes every pane but sets the system theme incorrectly to Light mode.
-dark: this suffix does not theme every pane but does set the system theme correctly to Dark mode

[nullishamy]

My further testing on Fedora Workstation (40) (VM)

Fedora workstation does not care about the suffix, only about the presence of gtk-dark.css. the system theme does not impact our gtk theme at all.

GNOME 46 on Wayland

[nullishamy]

dracula/gtk#264 (comment) A secondary report of the Pop!OS issue

[nullishamy]

See #262.