Pull request for the issue 357 #241
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kewaljani please close this PR. |
cgangelog review comments
lint screenshots added images Review comments spyder screenshot pycharm added
* histogram nulls support' * histogram nulls support with changelog' * histogram support with new test * test updated * updating changelog * updated magic-plot.md for histogram * updated magic-plot.md for histogram nulls * removing test notebook * updated facet-wrapper to support nulls * updated facet-wrapper to support nulls with test * spell-check * spell-check lint check * changed filter logic * changed filter logic removed local scripts * yield ip added * removed intermediate table for nulls and function-name-changes * removed intermediate table for nulls and function-name-changes * comments restructuring * comments restructuring and renaming * filter_aggregate now accepts multiple arguments, ggplot has a test with dummy data
* Update: comments * Update: comments
* 20x bottom padding * 20x bottom padding with changelog * 20x bottom padding remove scripts
* Add: example * fix lint * Fix: doc * fix lint * fix typo --------- Co-authored-by: Eduardo Blancas <[email protected]>
alias Review comments
* Fix intregration testing * Updated CI * Modified CI * install pkgmt * Changed Layout
* change port * Revert mariadb version * revert port, use old version
* pretty table styling fix * add styling test * add styling example in config doc * add styling example in config api doc
trigger workflows ../../.github/workflows/ci.yaml Workflow edited moved workflow fail changed path moved to test moved to test moved to test moved to test moved to test added versions baseline images wildcard integration Uploading entire folder live revert baseline Empty commit
* removed clickhouse * removed clickhouse from nox * Empty
It was missing the self argument. But it also isn't needed at all.
…#1016) * fix: query config value must be coniverted to dict to be usable by URL.create() * lint * changelog * changelog * docstring * lint * typos * fix: unpin duckdb version * fix: snippet tests * fix: json tests * fix: remove test * fix: mysql integration tests * fix: json tests * fix: rename to parse_config_section * fix: failing oracle integration test 'ip_with_oracle' * fix: broken link to CI db integration badge * doc: add example config with query parameters * fix: revert overzealous rebases * ci --------- Co-authored-by: Van Leuven Wim (100) <[email protected]> Co-authored-by: Eduardo Blancas <[email protected]>
* Remove sqlalchemy upper bound * Update CHANGELOG.md
* removes ploomber-extension * ci * ci fix * pin duckdb * rm doc * toc --------- Co-authored-by: neelasha23 <[email protected]>
* removes telemetry * fix
* fix * drops python 3.8 * update * skip test * updates lock file * fix * config update * removes problematic test * fix * disables integration tests * ci * typo
* adds test * lint * fix * adds note * changelog * fix * fix * adds note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for the issue 357