Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics of disk usage #49

Merged
merged 5 commits into from
Mar 6, 2024
Merged

Conversation

whywaita
Copy link
Contributor

This PR adds a new feature that metrics for disk usage.

You can see an example in Actions of my repo.

@whywaita
Copy link
Contributor Author

Hi @rwxdash, What do you think about this change?

@echoix
Copy link

echoix commented Nov 14, 2023

I’d be interested in something like this, since we regularly have to debug remaining disk space in building the various Megalinter images.

@serkan-ozal
Copy link
Member

Hi @whywaita,

Thanks for your contribution and sorry for late reply. Could you please rebase your PR with latest changes?

@whywaita
Copy link
Contributor Author

@serkan-ozal I'm done.

@whywaita
Copy link
Contributor Author

whywaita commented Mar 1, 2024

Hi @serkan-ozal , Is there anything I should do?

@serkan-ozal
Copy link
Member

Hi @whywaita,

I have seen that you have deleted process tracer binaries (proc_tracer_ubuntu-20 and proc_tracer_ubuntu-22) in your PR. They are required eBPF executables to trace process activities. Was it intentional? If so, what was the reason?

@serkan-ozal
Copy link
Member

@whywaita
Other than deleted files, the overall PR looks good.

@serkan-ozal
Copy link
Member

@rwxdash could you please review too

@whywaita
Copy link
Contributor Author

whywaita commented Mar 2, 2024

@serkan-ozal

I have seen that you have deleted process tracer binaries (proc_tracer_ubuntu-20 and proc_tracer_ubuntu-22) in your PR. They are required eBPF executables to trace process activities. Was it intentional? If so, what was the reason?

Oh, sorry. I have no reason for the deleted binaries. I deleted a dist directory because I thinked only code-generated files.

@rwxdash
Copy link
Member

rwxdash commented Mar 4, 2024

Looks good to me as well, thank you @whywaita. Just to be sure, can you re-run your example action, before we merge the PR. It seems to be expired.

@whywaita
Copy link
Contributor Author

whywaita commented Mar 4, 2024

You can check it at https://github.com/whywaita/actions-runner-images-lxd/actions/runs/8133293638. (CI is a failure 😿 but metrics are correct!)

@serkan-ozal
Copy link
Member

Thanks for your contribution @whywaita.

@serkan-ozal serkan-ozal merged commit c4a3f68 into catchpoint:master Mar 6, 2024
1 check passed
@whywaita
Copy link
Contributor Author

whywaita commented Mar 6, 2024

Thank you!

@whywaita whywaita deleted the add-disk-space branch May 1, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants