PHP JS Test - Tom Whittington #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First commit, added my own Framework, PHPExcel. When you load the site, landing page probes the database. If there are no entries, it copies the customers.csv file across.
AJAX Works and table presents information. Deleted uneccesarry file in controller. Minor bug on presentation; an extra line of data exists and throws everything out one line.
DB Data entry bug fixed, didn't account CSV file's ID column as well as adding my own auto increment.
Reduced table text size to prevent screen overlap. Commented a couple of lines on populateDB. Removed Uneccasarry file.
Added information to Readme.md and added catchtest.sql database creation file.
Added a little more information regarding the database.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've done the test as requested. Let me know if you think there's anything I need to/ should change, or anything like that.
Kind Regards,
Tom