Closes #450. Fixed cohort factor list.#452
Open
haiksu wants to merge 2 commits intocatalyst:MOODLE_400_STABLEfrom
Open
Closes #450. Fixed cohort factor list.#452haiksu wants to merge 2 commits intocatalyst:MOODLE_400_STABLEfrom
haiksu wants to merge 2 commits intocatalyst:MOODLE_400_STABLEfrom
Conversation
Removed unnecessary global $DB
Member
|
Thanks @haiksu - please note that as this plugin is now part of Moodle core - we need to address any issues/bugs/improvements in the upstream "latest" release before we backport to this repository to support older Moodle sites. If you end up creating an upstream Moodle tracker for this and fixing it there - please come back and post the details here so we can then look at merging this into the repo here for older sites - otherwise we need to close this as "won't fix." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using
cohort_get_all_cohorts()method, which returns only 25 cohorts, this modification fetches all the cohorts straight from the database without limitations.