Support multiple idp's with the same metadata URL #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Entryid is not unique. Could result in same idp's entryid would only show last.
Oversight on inital changes, resulting in rows not being deleted, as expected when updating idp's
#1 - Allow multiple idp's with the same metadatalink
|
I haven't looked at this properly, but one thing we need to make sure doesn't happen is that people's hard coded links from say their portal into moodle which embed query params of an idp do not need to change. It looks to me like this is a breaking change, so maybe the way forward is for the ?idp=xxx param to accept the old and new way so its backwards compatible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to solve: #796