Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix strtolower calls incompatible with utf-8 #725

Open
wants to merge 1 commit into
base: MOODLE_39_STABLE
Choose a base branch
from
Open

fix strtolower calls incompatible with utf-8 #725

wants to merge 1 commit into from

Conversation

skodak
Copy link
Contributor

@skodak skodak commented Sep 26, 2022

No description provided.

@skodak
Copy link
Contributor Author

skodak commented Sep 26, 2022

Please note I did not test this patch and I am not sure the upstream library actually supports utf-8 usernames.

@danmarsden
Copy link
Member

Thanks Petr - good spotting, this is pretty historic (we've always just used php's strtolower for this) but we should probably add some utf-8 tests to the user_extractor_test class to cover this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skodak @danmarsden