Update _base.py #2053
Open
Update _base.py #2053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for this great package! I encountered a small formatting issue when reading a JSON file after saving it using index_reader.dump_documents_BM2. I found a simple solution that worked well for me: adding encoding="utf-8" while saving the file. Additionally, regarding the issue with Arguana that I raised recently, I discovered the root cause. It is related to the document with docid 'training-society-iasihbmubf-pro06a', which appears to be empty. To address such cases, I would like to suggest a workaround for handling empty documents until the Java code is fixed. This might help others avoid similar issues. Thank you for your consideration!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for this great package! I encountered a small formatting issue when reading a JSON file after saving it using
index_reader.dump_documents_BM2. I found a simple solution that worked well for me: addingencoding="utf-8"while saving the file.Additionally, regarding the issue with Arguana that I raised recently, I discovered the root cause. It is related to the document with docid 'training-society-iasihbmubf-pro06a', which appears to be empty. To address such cases, I would like to suggest a workaround for handling empty documents until the Java code is fixed. This might help others avoid similar issues. Thank you for your consideration!