Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nullable reference type annotations to DynamicProxy's public API #668

Conversation

stakx
Copy link
Member

@stakx stakx commented Sep 14, 2023

No description provided.

@stakx stakx changed the title Add nullable reference type annotations to public API Add nullable reference type annotations to DynamicProxy's public API Sep 14, 2023
@stakx stakx force-pushed the enhancement/nullable-reference-type-annotations branch from 3e5cfd5 to 781960a Compare September 14, 2023 19:14
@stakx stakx force-pushed the enhancement/nullable-reference-type-annotations branch 2 times, most recently from a58f704 to 30bafc9 Compare September 15, 2023 08:47
@stakx stakx force-pushed the enhancement/nullable-reference-type-annotations branch from 30bafc9 to 5405a0d Compare August 30, 2024 15:58
@stakx stakx force-pushed the enhancement/nullable-reference-type-annotations branch from 5405a0d to 7122b6c Compare August 30, 2024 16:14
@stakx
Copy link
Member Author

stakx commented Aug 30, 2024

@jonorossi, quick question because it's been a while since I worked with .NET in-depth, and I'm not sure I remember correctly: IIRC, the nullable hints get encoded in custom attributes. Does the addition of custom attributes to types and methods cause a binary breaking change that would require downstream code to be recompiled, or not? I don't think so, but if it were, we would probably need to bump the major version when merging this.

P.S.: You can ignore the above question, I just remembered: unlike modifiers (modreqs and modopts), custom attributes are not part of the type/method signatures, therefore the addition of attributes should not cause any breaking changes. I ran a quick experiment which confirms this. So this PR should be safe to merge in a non-major version.

@stakx stakx merged commit 00642c9 into castleproject:master Aug 30, 2024
4 checks passed
@stakx stakx deleted the enhancement/nullable-reference-type-annotations branch August 30, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants