This repository has been archived by the owner on Dec 31, 2020. It is now read-only.
Restore 2 0 8 abi #275
Open
Restore 2 0 8 abi #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although adding a method argument with default argument keeps API compatibility, it changes the function type. Use function overloading instead and implement the old one as a wrapper to the extended one, supplying the default argument. Fixes part of castano#259 Signed-off-by: Stefan Brüns <[email protected]>
The linear transform has never been implemented, so just add as a stub for API/ABI compatibility. Fixes part of castano#259 Signed-off-by: Stefan Brüns <[email protected]>
The only colortransform actually implemented was the transform from RGB to YCoCG (ColorTransform_YCoCg). Restore the full enum for API compatibility, and allow the transform to be specified using InputOptions::setColortransform. Fixes part of castano#259 Signed-off-by: Stefan Brüns <[email protected]>
|
Failed check is unrelated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes all but one issue in #259
Only remaining incompatibility is the added virtual method OutputHandler::endImage()