-
Notifications
You must be signed in to change notification settings - Fork 77
Only support Kotlin 2.1 #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @TheKinrar for the PR. Awesome, that makes everything a bit easier. @marcospereira, @checketts what do you think, shall we move forward with this, so that we can have a release that works with the latest and greatest Kotlin again? |
Thanks for the packages @TheKinrar . I was able to pull them down and verify that my project is working with Kotlin 2.1.0 and JTE. So @casid yes, please move forward with this! |
@TheKinrar I think the Kotlin version needs to be adjusted in the following test gradle projects as well. jte-runtime-cp-test-models-gradle-kotlin After that's fixed, I think we should merge and release a new minor jte version. |
@casid Gradle decided to change the line endings of the gradlew.bat files when I updated it, thus the now significant diff although I did not change much. I can restore the old gradlew files if needed. Old Gradle versions caused a conflict because of their old embedded Kotlin version. |
Looks good, I'm merging this now! |
Hello, Thank you for the version upgrade of Kotlin. Have you scheduled a release of JTE with this correction ? |
Until they have an official JTE release with this change, this should work for you #412 (comment) |
As an alternative to #411, this PR removes support for Kotlin < 2.1 and simply requires Kotlin 2.1 going forward. I guess this might not be what you want, but works for me so I'm just pushing the (very minor) changes here in case it's of interest to someone!
I also have packages from this PR available on my repo: https://github.com/TheKinrar/jte