Skip to content

Conversation

TheKinrar
Copy link
Contributor

As an alternative to #411, this PR removes support for Kotlin < 2.1 and simply requires Kotlin 2.1 going forward. I guess this might not be what you want, but works for me so I'm just pushing the (very minor) changes here in case it's of interest to someone!

I also have packages from this PR available on my repo: https://github.com/TheKinrar/jte

@casid
Copy link
Owner

casid commented Feb 27, 2025

Thanks @TheKinrar for the PR. Awesome, that makes everything a bit easier.

@marcospereira, @checketts what do you think, shall we move forward with this, so that we can have a release that works with the latest and greatest Kotlin again?

@checketts
Copy link
Contributor

Thanks for the packages @TheKinrar . I was able to pull them down and verify that my project is working with Kotlin 2.1.0 and JTE.

So @casid yes, please move forward with this!

@casid
Copy link
Owner

casid commented Mar 4, 2025

@TheKinrar I think the Kotlin version needs to be adjusted in the following test gradle projects as well.

jte-runtime-cp-test-models-gradle-kotlin
jte-runtime-cp-test-gradle-kotlin
jte-runtime-test-gradle-kotlin-convention
jte-runtime-cp-test-gradle-kotlin-convention
kte-runtime-test-gradle-kotlin-convention

After that's fixed, I think we should merge and release a new minor jte version.

@TheKinrar TheKinrar marked this pull request as ready for review March 4, 2025 16:29
@TheKinrar
Copy link
Contributor Author

@casid Gradle decided to change the line endings of the gradlew.bat files when I updated it, thus the now significant diff although I did not change much. I can restore the old gradlew files if needed. Old Gradle versions caused a conflict because of their old embedded Kotlin version.

@casid
Copy link
Owner

casid commented Mar 6, 2025

Looks good, I'm merging this now!

@casid casid merged commit 84721bf into casid:main Mar 6, 2025
13 of 14 checks passed
@GregoryBevan
Copy link

Hello,

Thank you for the version upgrade of Kotlin. Have you scheduled a release of JTE with this correction ?

@JordanPlayz158
Copy link

Hello,

Thank you for the version upgrade of Kotlin. Have you scheduled a release of JTE with this correction ?

Until they have an official JTE release with this change, this should work for you #412 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants