Add resume from checksum #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgo
force-pushed
the
mtocker-resume-checksum
branch
from
26814cb
to
fdabcd1
Compare
morgo
force-pushed
the
mtocker-resume-checksum
branch
2 times, most recently
from
5ba57eb
to
846175f
Compare
morgo
force-pushed
the
mtocker-resume-checksum
branch
from
846175f
to
4c974e0
Compare
prudhvi
reviewed
Sep 3, 2024
prudhvi
approved these changes
Sep 3, 2024
prudhvi
reviewed
Sep 3, 2024
| if r.dbConfig == nil { | ||
| r.dbConfig = dbconn.NewDBConfig() | ||
| } | ||
| r.db.SetMaxOpenConns(r.dbConfig.MaxOpenConnections + 2) | ||
| var err error | ||
| for i := range 3 { // try the checksum up to 3 times. | ||
| if i > 0 { | ||
| r.checksumWatermark = "" // reset the watermark if we are retrying. | ||
| } |
There was a problem hiding this comment.
Is this intentional? so resume from checksum watermark only works if first resume is successful, otherwise it starts checksum from scratch again?
There was a problem hiding this comment.
Yes that's right. If there is any failure we recheck everything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Pull Request should be associated with an Issue.
This fixes #317
In our case we support yield via automation (pod cycling every 24hrs), so I am going to call this fixed.. even though it only completes part of the described FR.
Also fixes #320 and fixes #315 - the root cause is depending when the context cancel is detected, the error message can vary.