Adds support for mcp server instructions #3430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for server instructions in the misk-mcp library by introducing an optional instructionsProvider parameter to the MiskMcpServer and McpServerModule classes. The feature prepares the codebase for providing server instructions once the underlying kotlin-sdk supports it.
Key changes:
- Added
instructionsProviderparameter toMiskMcpServerconstructor - Updated
McpServerModuleto accept and pass through the instructions provider - Modified API signatures to include the new optional parameter
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| misk-mcp/src/main/kotlin/misk/mcp/MiskMcpServer.kt | Added instructionsProvider parameter with TODO comment for future SDK support |
| misk-mcp/src/main/kotlin/misk/mcp/McpServerModule.kt | Updated module constructor and factory methods to handle instructions provider |
| misk-mcp/api/misk-mcp.api | Updated API signatures to reflect new parameter additions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jclyne
force-pushed
the
jclyne.09-26-adds_support_for_server_instructions
branch
4 times, most recently
from
4833672 to
f86b44c
Compare
jclyne
force-pushed
the
jclyne.09-26-adds_support_for_server_instructions
branch
from
f86b44c to
61c13c3
Compare
ean5533
added a commit
that referenced
this pull request
Oct 9, 2025
…tric * origin/master: (22 commits) feat: add UrlMatcher to inspect if the Misk Application has a handler for a given URL (#3457) Fix edge-case issue with `RetryingTransacter` (#3456) Add http_response_header_size to WebConfig (#3453) add blpop to redis (#3441) fix post message request field name (#3450) Support getChatPermalink and threaded responses on slack api (#3447) misk-hibernate: use single connection in Vitess shard targeting and improve interface (#3409) [bug fix] Fix `del` operation in FakeRedis.kt (#3449) fix: Use TCCL to load classes (#3448) adds support for server instructions (#3430) misk-testing: create TestFixtureBindingValidator (#3440) fix: flaky ExclusiveTimingInterceptorTest (#3446) fix: some more flakiness in SubscriptionTest (#3445) Bump form-data in /misk-admin/web-actions/development-proxy (#3432) fix: flaky SqsJobQueueTest (#3438) Misk servlet embeddable to an external servlet containers (#3435) feat: reattempt in introducing configurable http/2 control frame limiter with observability (#3422) fix: flaky SubscriptionTest (#3437) Bump tar-fs from 2.1.1 to 2.1.4 (#3431) Bump sha.js from 2.4.11 to 2.4.12 in /misk-admin/web/tabs/database (#3434) ... # Conflicts: # misk-mcp/src/main/kotlin/misk/mcp/McpServerModule.kt # misk-mcp/src/main/kotlin/misk/mcp/MiskMcpServer.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
{public}Adds support for providing server instructions in the misk-mcp MiskMspServers.{/public}
NOTE: This is not currently supported by the kotlin-sdk, so it won't actually show up in the
InitializeResultyet. Its being added to misk-mcp so servers can begin implementing itRelated Work
Checklist