Skip to content

Remove @MainActor annotation from assemble #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Remove @MainActor annotation from assemble #270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Sources/Knit/Module/ModuleAssembly.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ public protocol ModuleAssembly {

static var dependencies: [any ModuleAssembly.Type] { get }

@MainActor func assemble(container: Container)
// Knit will always call assemble on the MainActor. The annotation is not included because Swift is unable to
// correctly check the concurrency of closures inside a @MainActor function
func assemble(container: Container)

/// A ModuleAssembly can replace any number of other module assemblies.
/// If this assembly replaces another it is expected to provide all registrations from the replaced assemblies.
Expand Down