Generic Container with support for TargetResolver #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skorulis-ap
reviewed
Mar 17, 2025
skorulis-ap
reviewed
Mar 17, 2025
bradfol
force-pushed
the
bradfol/specified
branch
from
f70c01c to
d086208
Compare
bradfol
changed the title
skorulis-ap
reviewed
Mar 18, 2025
Sources/Knit/WeakResolver.swift
Outdated
There was a problem hiding this comment.
Will WeakResolver still be needed going forwards? We might be able to remove this in a later PR.
There was a problem hiding this comment.
Yep that's one of my follow up items. It should no longer be needed
skorulis-ap
reviewed
Mar 18, 2025
bradfol
force-pushed
the
bradfol/specified
branch
2 times, most recently
from
4e0b2ae to
7d12123
Compare
skorulis-ap
approved these changes
Mar 18, 2025
When using a single ModuleAssembler it can be useful for it to ignore TargetResolvers for its assemblies. The app target use case is an app that only has a single TargetResolver, often `Knit.Resolver`. The test target use case is when a single ModuleAssembler is used for multiple TargetResolvers for simplicity of test setup.
bradfol
force-pushed
the
bradfol/specified
branch
from
7d12123 to
3956ba8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.