Skip to content

feat: optimizations when logging is disabled #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: optimizations when logging is disabled #453

wants to merge 1 commit into from

Conversation

ilia1243
Copy link

@ilia1243 ilia1243 commented May 9, 2025 •
edited
Loading

  • Log messaged are now lazily evaluated.
  • Util.logPrintf is made deprecated.

Fixes: #452

@CLAassistant
Copy link

CLAassistant commented May 9, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hsluoyz
Copy link
Member

hsluoyz commented May 10, 2025

@ilia1243 need to keep backward-compatibility

@ilia1243
Copy link
Author

@ilia1243 need to keep backward-compatibility

Done, but still propose to make old method deprecated, becauses SLF4J states that their approach is faster. https://www.slf4j.org/faq.html#logging_performance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimizations when logging is disabled
3 participants
@ilia1243 @CLAassistant @hsluoyz