Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Small fix #1

wants to merge 1 commit into from

Conversation

rajesh06
Copy link

@rajesh06 rajesh06 commented Mar 28, 2023

Brian - I had to make this small fix to deal with an error.
This is the error:

Caused by error in `fct_other()`:
! `drop` must be a character vector, not an integer vector.

and I presume that's because other_lags was (or was coerced to) a numeric vector.

@ResearchActuary
Copy link
Member

Did you get the error when rendering linear_mixed_models.qmd? I'm able to render without error. This may be because I'm using a slightly updated version of linear_mixed_models.qmd. I'll push my version up to main. Can you try running again once I've done that?

All that understood, the adjust_lags() function looks pretty harmless. We're expecting the lag column and the max_lag function argument to be integers. Possibly the data frame you're using has lag as a character?

BTW, at some point, I'd love to work on an R package to codify some reserve data frame properties and operations. I had a go at that with the MRMR package, but would love to have another go. MRMR used S4 classes. I envision something akin to tibble which extends a data frame, but has an object which can be treated like a data frame.

@ResearchActuary
Copy link
Member

I spoke to soon about my version of linear_mixed_models.qmd. Just checked the status on my local project and "nothing to commit, working tree clean".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants