feat: added the functionality to save images from the clipboard to PN… #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
huaiyinfeilong
commented
Apr 29, 2024
huaiyinfeilong
commented
- Added the functionality to save images from the clipboard to PNG files using the hotkey NVDA+Alt+Print Screen.
- Modified the clipboard editor to save images in PNG format.
…G files using a hotkey * Added the functionality to save images from the clipboard to PNG files using the hotkey NVDA+Alt+Print Screen. * Modified the clipboard editor to save images in PNG format.
cary-rowen
reviewed
May 24, 2024
Comment on lines
+907
to
+909
| import sys | ||
| import os | ||
| sys.path.append( |
There was a problem hiding this comment.
Would you mind moving the import to the top?
cary-rowen
reviewed
May 24, 2024
Comment on lines
+914
to
+916
| from PIL import Image, ImageGrab | ||
| from io import BytesIO | ||
| try: |
There was a problem hiding this comment.
Ditto, I think this could also be moved to the top
cary-rowen
reviewed
May 24, 2024
Comment on lines
+236
to
245
| import sys | ||
| import os | ||
| sys.path.append( | ||
| os.path.abspath( | ||
| os.path.join(os.path.dirname(__file__), "..", "_py3_contrib") | ||
| ) | ||
| ) | ||
| from PIL import Image, ImageGrab | ||
| from io import BytesIO | ||
| try: |
There was a problem hiding this comment.
This also does the same thing, i.e. moves the imports to the top
|
"I think it can be moved to the top. Previously, there was an issue because we weren't using the VSCode configuration within the plugin template, which caused a warning to appear when moved to the top, specifically after os.sys…"
发件人: ***@***.*** ***@***.***> 代表 Rowen
发送时间: 2024年5月24日 20:07
收件人: cary-rowen/clipboardEnhancement ***@***.***>
抄送: huaiyinfeilong ***@***.***>; Author ***@***.***>
主题: Re: [cary-rowen/clipboardEnhancement] feat: added the functionality to save images from the clipboard to PN… (PR #16)
@cary-rowen commented on this pull request.
_____
In addon/globalPlugins/clipboardEnhancement/__init__.py <#16 (comment)> :
+ import sys
+ import os
+ sys.path.append(
Would you mind moving the import to the top?
—
Reply to this email directly, view it on GitHub <#16 (review)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADKMFL4NMLOIP2SY5IWXL5TZD4UP3AVCNFSM6AAAAABG522KK2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANZWG4ZTOMJQHE> .
You are receiving this because you authored the thread. <https://github.com/notifications/beacon/ADKMFL5JQRB2J3XS7IQPCNTZD4UP3A5CNFSM6AAAAABG522KK2WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTT3ZB7FK.gif> Message ID: ***@***.*** ***@***.***> >
|
|
"I think it can be moved to the top. Previously, there was an issue because we weren't using the VSCode configuration within the plugin template, which caused a warning to appear when moved to the top, specifically after os.sys…"
发件人: ***@***.*** ***@***.***> 代表 Rowen
发送时间: 2024年5月24日 20:09
收件人: cary-rowen/clipboardEnhancement ***@***.***>
抄送: huaiyinfeilong ***@***.***>; Author ***@***.***>
主题: Re: [cary-rowen/clipboardEnhancement] feat: added the functionality to save images from the clipboard to PN… (PR #16)
@cary-rowen commented on this pull request.
_____
In addon/globalPlugins/clipboardEnhancement/__init__.py <#16 (comment)> :
+ from PIL import Image, ImageGrab
+ from io import BytesIO
+ try:
Ditto, I think this could also be moved to the top
—
Reply to this email directly, view it on GitHub <#16 (review)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADKMFL6JRLBHP75ZTRFJ6YLZD4UWTAVCNFSM6AAAAABG522KK2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANZWG42DEOJUGM> .
You are receiving this because you authored the thread. <https://github.com/notifications/beacon/ADKMFL2EIEZNDTZEU4X6FTDZD4UWTA5CNFSM6AAAAABG522KK2WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTT3ZCKR6.gif> Message ID: ***@***.*** ***@***.***> >
|
|
"I think it can be moved to the top. Previously, there was an issue because we weren't using the VSCode configuration within the plugin template, which caused a warning to appear when moved to the top, specifically after os.sys…"
发件人: ***@***.*** ***@***.***> 代表 Rowen
发送时间: 2024年5月24日 20:13
收件人: cary-rowen/clipboardEnhancement ***@***.***>
抄送: huaiyinfeilong ***@***.***>; Author ***@***.***>
主题: Re: [cary-rowen/clipboardEnhancement] feat: added the functionality to save images from the clipboard to PN… (PR #16)
@cary-rowen commented on this pull request.
_____
In addon/globalPlugins/clipboardEnhancement/clipEditor.py <#16 (comment)> :
+ import sys
+ import os
+ sys.path.append(
+ os.path.abspath(
+ os.path.join(os.path.dirname(__file__), "..", "_py3_contrib")
+ )
)
+ from PIL import Image, ImageGrab
+ from io import BytesIO
try:
This also does the same thing, i.e. moves the imports to the top
—
Reply to this email directly, view it on GitHub <#16 (review)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADKMFL6CQRSZUP4PAWOWOVDZD4VDTAVCNFSM6AAAAABG522KK2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANZWG42TGOBZHE> .
You are receiving this because you authored the thread. <https://github.com/notifications/beacon/ADKMFL25XLXA2F3G45U5PFDZD4VDTA5CNFSM6AAAAABG522KK2WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTT3ZC76W.gif> Message ID: ***@***.*** ***@***.***> >
|
|
Thanks @huaiyinfeilong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.