http-prover refactor #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chudkowsky
added a commit
that referenced
this pull request
Feb 6, 2025
This reverts commit cfe5ec6.
matzayonc
reviewed
Feb 6, 2025
| #[clap(subcommand)] | ||
| command: Subcommands, | ||
| } | ||
| #[allow(clippy::large_enum_variant)] |
matzayonc
reviewed
Feb 6, 2025
| pub fn handle_completed_job_response(result: JobResult) -> RunResult { | ||
| match result { | ||
| JobResult::Prove(_) => { | ||
| panic!("Expected a prove result, but got a run result",); |
matzayonc
reviewed
Feb 6, 2025
| #[derive(Debug, Clone, PartialEq, Serialize, Deserialize)] | ||
| pub struct CairoProverInput { | ||
| pub program: CairoCompiledProgram, | ||
| pub program_input: Vec<Felt>, | ||
| pub layout: Layout, | ||
| pub layout: super::Layout, |
There was a problem hiding this comment.
I think absolute paths are good practice
matzayonc
reviewed
Feb 6, 2025
| common::models::JobStatus::Failed, | ||
| Some(e.to_string()), | ||
| ) | ||
| .await; | ||
|
|
||
| let sender = sse_tx.clone(); | ||
| let sender = sender.lock().await; | ||
| if sender.receiver_count() > 0 { |
There was a problem hiding this comment.
Is there a case where recv is not yet called due to congestion and we lose the response?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce New HTTP-Prover API
This PR introduces a new HTTP-based prover API and adds several key enhancements:
New Trace Generation Endpoint
Prover CLI Enhancements
cairo-provewith a new Prover CLI.Server-Side Improvements
cairo0program representation:StructtoVec<u8>due to serialization/deserialization issues (to be investigated further).