Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add dist to gitignore #30

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: add dist to gitignore #30

wants to merge 1 commit into from

Conversation

glihm
Copy link

@glihm glihm commented Mar 12, 2025

Without this dist added to the gitignore, Katana is still reporting changes in the submodule related to the explorer/ui.

Adding it ensures the new build.rs in Katana is not generating a git diff.

Copy link

vercel bot commented Mar 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
explorer-sepolia ✅ Ready (Inspect) Visit Preview Mar 12, 2025 3:08am
explorer-starknet ✅ Ready (Inspect) Visit Preview Mar 12, 2025 3:08am

@glihm glihm changed the title fix: add dist to gitignore chore: add dist to gitignore Mar 12, 2025
@glihm glihm requested review from ayushtom and kariy March 12, 2025 03:08
@glihm
Copy link
Author

glihm commented Mar 12, 2025

Actually not sure, seems dist is actually in the .git. I miss context there, each time we rebuild some content is changed, but must be committed?

@glihm glihm marked this pull request as draft March 12, 2025 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant