refactor(block details): selector component and slight table redesign #29
+1,817
−221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kariy is attempting to deploy a commit to the cartridge Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
For this component: 
I decided to just use my current design for now. I think it's a bit too '✨✨'. I will try to simplify based on you comment on Figma. |
ayushtom
reviewed
Mar 13, 2025
| cell: (info) => ( | ||
| <TableCell | ||
| onClick={() => navigateToTxn(info.renderValue())} | ||
| className="w-full flex items-center overflow-hidden cursor-pointer pr-4 hover:text-blue-400 transition-all" | ||
| className="w-full hover:underline hover:text-gray-300 cursor-pointer pr-4" |
There was a problem hiding this comment.
i think this is too light. can we have a darker shade?
There was a problem hiding this comment.
I think these filters are not working
https://github.com/user-attachments/assets/28673d34-c0ec-4aa1-9345-d2a22029cdcb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a bit of refactor on the table stuff. refactor out the transaction list table into its own component (will do the same for the other data ie events, messages, state updates) so it's easier to manage.
Before:
After: