Cleanup dependencies #1430
Open
Cleanup dependencies #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JunichiSugiura
force-pushed
the
chore/cleanup-deps
branch
from
9cb20cb to
1c8778e
Compare
JunichiSugiura
force-pushed
the
chore/cleanup-deps
branch
from
1c8778e to
a6fe94e
Compare
JunichiSugiura
force-pushed
the
chore/cleanup-deps
branch
from
a6fe94e to
987862c
Compare
tarrencev
reviewed
Feb 26, 2025
| @@ -71,6 +71,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@cartridge/eslint": "workspace:^", | |||
| "@cartridge/presets": "catalog:", | |||
There was a problem hiding this comment.
This is used in storybook for mainly layout thus devDependencies.
| @@ -28,6 +28,7 @@ | |||
| "viem": "catalog:" | |||
| }, | |||
| "devDependencies": { | |||
| "@cartridge/presets": "catalog:", | |||
There was a problem hiding this comment.
This is used to pass ERC20 icons to ERC20 class. In the future, it should be provided via gateway API.
| @@ -30,9 +30,6 @@ | |||
| "test:storybook": "pnpm turbo build:deps test:storybook", | |||
| "test:storybook:update": "pnpm turbo build:deps test:storybook:update" | |||
| }, | |||
| "dependencies": { | |||
| "@cartridge/presets": "github:cartridge-gg/presets#c7e6fb7" | |||
There was a problem hiding this comment.
we need to make sure this change works with the presets update ci
There was a problem hiding this comment.
Good point !
JunichiSugiura
force-pushed
the
chore/cleanup-deps
branch
from
987862c to
e6649e1
Compare
JunichiSugiura
force-pushed
the
chore/cleanup-deps
branch
from
e6649e1 to
4b276bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related