refactor: send raw json when callback uri #1323
Open
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🎨 Visual Regression Test Results✅ No visual changes detected |
tarrencev
reviewed
Jan 24, 2025
| @@ -75,7 +71,7 @@ export function Session() { | |||
| } | |||
|
|
|||
| const res = await fetch(url, { | |||
| body: encodedResponse, | |||
| body: JSON.stringify(response), | |||
There was a problem hiding this comment.
i think slot goes through another flow no? the oauth stuff
There was a problem hiding this comment.
ah yeah what about sozo though? doesn't it use this flow to create a cli controller?
There was a problem hiding this comment.
ah ok yes that will need to be changed to use the decode the raw json directly. i just wonder if the flow still works because the rev that slot uses for the account_sdk is outdated and when i used it, i had deserialization errors when initializing and using a session account. @glihm do you know if it still works fine?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.