Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code to work with recent abseil changes #1919

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update code to work with recent abseil changes #1919

wants to merge 1 commit into from

Conversation

kkufieta
Copy link

@kkufieta kkufieta commented Feb 28, 2023 •
edited
Loading

This patch fixes compilation issues caused by the most recent changes to abseil-cpp: https://github.com/abseil/abseil-cpp/releases:

The legacy spellings of the thread annotation macros/functions (e.g. GUARDED_BY()) have been removed by default in favor of the ABSL_ prefixed versions (e.g. ABSL_GUARDED_BY()) due to clashes with other libraries. The compatibility macro ABSL_LEGACY_THREAD_ANNOTATIONS can be defined on the compile command-line to temporarily restore these spellings, but this compatibility macro will be removed in the future.

@kkufieta
Update code to work with recent abseil changes
da4d12c 
Signed-off-by: Katharina Xenia Kufieta <[email protected]>
@kkufieta
Copy link
Author

Gentle ping - I would love to get these changes merged so we can stop using the ABSL_LEGACY_THREAD_ANNOTATIONS compatibility macro before it is going to be removed in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kkufieta