Merged
Conversation
stephenctw
reviewed
Mar 23, 2026
| testsi = { version = "0.1", git = "https://github.com/GCdePaula/cartesi-tools-rs", rev = "27b457994546ea4a8345ed078031782f155d3013" } | ||
| types = { version = "0.1", git = "https://github.com/GCdePaula/cartesi-tools-rs", rev = "27b457994546ea4a8345ed078031782f155d3013" } | ||
| cartesi-machine = { version = "2", git = "https://github.com/cartesi/dave", rev = "5d0560a04f623318af9ef5b7f193170b618b6ced", default-features = false, features = ["download_uarch"] } | ||
| libcmt-sys = { version = "0.1", git = "https://github.com/GCdePaula/cartesi-tools-rs", rev = "c2b2f65bc6a3d4ddf80b3a0c5a1673fbf22e9f86" } |
Collaborator
There was a problem hiding this comment.
Workspace deps still pin GCdePaula/cartesi-tools-rs (and related git SHAs). Before merging to cartesi/sequencer, consider whether those should live under cartesi/ (or crates.io) so the org does not rely on a personal fork long term.
| self.nonces.insert(user_op.sender, next_nonce); | ||
| self.executed_input_count = self.executed_input_count.saturating_add(1); | ||
| Ok(()) | ||
| Ok(Vec::new()) |
Collaborator
There was a problem hiding this comment.
On success, we return an empty vector, and the AppOutputs is also not processed by the caller. Is it intentional because we are working on a toy app for now?
Collaborator
Author
There was a problem hiding this comment.
This array is being used in other parts of the code. It's not being used in the inclusion lane.
The wallet returns non-empty arrays.
| } | ||
|
|
||
| fn execute_direct_input(&mut self, _input: &DirectInput) -> Result<(), AppError> { | ||
| fn execute_direct_input(&mut self, _input: &DirectInput) -> Result<AppOutputs, AppError> { |
|
|
||
| fn execute_valid_user_op(&mut self, _user_op: &ValidUserOp) -> Result<(), AppError> { | ||
| Ok(()) | ||
| fn execute_valid_user_op(&mut self, _user_op: &ValidUserOp) -> Result<AppOutputs, AppError> { |
| } | ||
|
|
||
| fn execute_direct_input(&mut self, _input: &DirectInput) -> Result<(), AppError> { | ||
| fn execute_direct_input(&mut self, _input: &DirectInput) -> Result<AppOutputs, AppError> { |
| } | ||
|
|
||
| fn execute_valid_user_op(&mut self, user_op: &ValidUserOp) -> Result<(), AppError> { | ||
| fn execute_valid_user_op(&mut self, user_op: &ValidUserOp) -> Result<AppOutputs, AppError> { |
| } | ||
|
|
||
| fn execute_direct_input(&mut self, input: &DirectInput) -> Result<(), AppError> { | ||
| fn execute_direct_input(&mut self, input: &DirectInput) -> Result<AppOutputs, AppError> { |
Collaborator
|
Looks great! I left a few minor comments. |
stephenctw
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.