Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve machine-runner test #97

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Improve machine-runner test #97

merged 2 commits into from
Jan 14, 2025

Conversation

stephenctw
Copy link
Collaborator

@stephenctw stephenctw commented Jan 13, 2025 •
edited
Loading

  • abstract machine instance from the test
  • fix state-access test

@stephenctw stephenctw requested a review from GCdePaula January 13, 2025 02:58
@stephenctw stephenctw self-assigned this Jan 13, 2025
@stephenctw stephenctw force-pushed the feature/machine-runner-tests branch from 321e9dd to d3a2272 Compare January 13, 2025 03:16
@stephenctw stephenctw changed the base branch from main to feature/cleanup January 13, 2025 13:51
@stephenctw stephenctw force-pushed the feature/machine-runner-tests branch from d3a2272 to 2ece9ec Compare January 13, 2025 14:01
GCdePaula
GCdePaula approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@GCdePaula GCdePaula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

@stephenctw stephenctw merged commit 7b9473b into feature/cleanup Jan 14, 2025
2 checks passed
@GCdePaula GCdePaula mentioned this pull request Jan 14, 2025
Merged
@GCdePaula GCdePaula deleted the feature/machine-runner-tests branch January 17, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GCdePaula GCdePaula GCdePaula approved these changes

Assignees

@stephenctw stephenctw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephenctw @GCdePaula