feat: store car alongside content on s3 to then move it in a deterministic way to ipfs #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 22, 2024 19:01
guerrap
approved these changes
Jan 23, 2024
guerrap
reviewed
Jan 24, 2024
guerrap
reviewed
Jan 24, 2024
src/utils.ts
Outdated
| region: "us-east-1", | ||
| credentials: { | ||
| accessKeyId, | ||
| secretAccessKey, | ||
| }, | ||
| }); | ||
|
|
||
| const putBucketLifecycleConfiguration = |
There was a problem hiding this comment.
Why do we need the lifecycle configuration here?
There was a problem hiding this comment.
It's just to make sure it's always there. Since this full lifecycle and its whole concept is managed by this specific service it makes sense that it's created here instead of Terraform no?
guerrap
reviewed
Jan 24, 2024
src/routes/data/ipfs.ts
Outdated
| notes: "Stores JSON data on S3. The data has to have previously been stored on S3 in a format that the service can understand and the caller must be explicitly authorized to call this endpoint.", | ||
| description: "Replicates limbo data to IPFS.", | ||
| notes: | ||
| "Replicated limbo data to IPFS. The data has to be already existing and " + |
There was a problem hiding this comment.
Small typo here Replicated.
guerrap
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.