Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI test matrix #179

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wynksaiddestroy
Copy link

@wynksaiddestroy wynksaiddestroy commented Jan 25, 2024

I just brought the GitHub testing workflow up to date:

  • add Ruby 3.3 and head
  • remove unmaintained Ruby versions (EOL) 2.5, 2.6 and 2.7
  • use the latest available Ubuntu version
  • use the latest actions/checkout version (v4)

@@ -8,14 +8,14 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: [ '2.5', '2.6', '2.7', '3.0', '3.1', '3.2', jruby ]
ruby: [ '3.0', '3.1', '3.2', '3.3', head, jruby ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for responding late 🙇‍♂️
Would you mind keeping 2.x Rubies? If this was an app it's fine, but libraries, including carrierwave-aws, are better be permissive on its dependencies I think, as users may have a reason that prevents from upgrading.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your reply. I'm not sure what the consensus is on unmaintained Ruby versions. I'm obviously not in a position to decide that. But I think that supporting old versions also leads to people not updating their software. In the end that means that they are running insecure software. Also, people with old Ruby versions might still be using old versions of this gem. Maybe someone else has an opinion on this topic. I can also just add the old versions back, if that's the prevailing opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants