Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "Search All in One" aware of learner/instructor distinction #136

Merged
merged 4 commits into from
May 21, 2024

Conversation

ErinBecker
Copy link
Contributor

Fixes #135

Clicking the "Search the All in One page" from Instructor view brings up the Instructor AIO (with Instructor notes shown):

Screenshot 2024-05-21 at 9 34 24 AM

While clicking "Search the All in One page" from the Learner view brings up the Learner version of the page (with no Instructor notes):

Screenshot 2024-05-21 at 9 34 33 AM

Thanks to @tobyhodges for noticing this and to @froggleston for help with the moustach syntax!

@froggleston froggleston merged commit 7068064 into main May 21, 2024
1 check passed
@froggleston froggleston deleted the search-instructor-aio branch May 21, 2024 17:07
@froggleston
Copy link
Contributor

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search button is unaware of Learner/Instructor View
2 participants