-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace anaconda #513
Replace anaconda #513
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/carpentries-incubator/deep-learning-intro/compare/md-outputs..md-outputs-PR-513 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-08-06 10:34:15 +0000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great @carschno! This greatly simplifies things.
I left some comments, before merging I think we should have someone on Windows test this.
@tobyhodges, @psteinb, or @colinsauze are you on Windows and could one of you test these new installation instructions? |
I'm on Linux, I do have Windows installed but not booted it in a while. I'll try and boot it later today and see if I can test things out. |
No need to test it again on Windows as @DaniBodor already did it! I think we can move forward with this. |
@carschno do you think we could merge this? |
Auto-generated via {sandpaper} Source : 9954a29 Branch : main Author : Carsten Schnober <[email protected]> Time : 2024-08-20 15:33:25 +0000 Message : Merge pull request #513 from carpentries-incubator/replace_anaconda Replace anaconda
Auto-generated via {sandpaper} Source : ae517b9 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-08-20 15:34:23 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 9954a29 Branch : main Author : Carsten Schnober <[email protected]> Time : 2024-08-20 15:33:25 +0000 Message : Merge pull request #513 from carpentries-incubator/replace_anaconda Replace anaconda
Merge queue: should be merged after #512
Closes #511, using Pip/Venv installation.