Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve explanation of images in episode 1 #509

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

svenvanderburg
Copy link
Collaborator

Fixes #486

Copy link

github-actions bot commented Jul 23, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/deep-learning-intro/compare/md-outputs..md-outputs-PR-509

The following changes were observed in the rendered markdown documents:

 1-introduction.md | 26 ++++++++++++++++++++------
 md5sum.txt        |  2 +-
 2 files changed, 21 insertions(+), 7 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-07-23 08:58:53 +0000

@svenvanderburg svenvanderburg requested a review from carschno July 23, 2024 08:58
github-actions bot pushed a commit that referenced this pull request Jul 23, 2024
Copy link
Collaborator

@carschno carschno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@carschno carschno merged commit 184fd48 into main Jul 23, 2024
3 checks passed
@carschno carschno deleted the explain-network-figures-episode-1 branch July 23, 2024 09:08
github-actions bot pushed a commit that referenced this pull request Jul 23, 2024
Auto-generated via {sandpaper}
Source  : 184fd48
Branch  : main
Author  : Carsten Schnober <[email protected]>
Time    : 2024-07-23 09:07:59 +0000
Message : Merge pull request #509 from carpentries-incubator/explain-network-figures-episode-1

Improve explanation of images in episode 1
github-actions bot pushed a commit that referenced this pull request Jul 23, 2024
Auto-generated via {sandpaper}
Source  : 869e6e4
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-07-23 09:09:08 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 184fd48
Branch  : main
Author  : Carsten Schnober <[email protected]>
Time    : 2024-07-23 09:07:59 +0000
Message : Merge pull request #509 from carpentries-incubator/explain-network-figures-episode-1

Improve explanation of images in episode 1
github-actions bot pushed a commit that referenced this pull request Jul 30, 2024
Auto-generated via {sandpaper}
Source  : 184fd48
Branch  : main
Author  : Carsten Schnober <[email protected]>
Time    : 2024-07-23 09:07:59 +0000
Message : Merge pull request #509 from carpentries-incubator/explain-network-figures-episode-1

Improve explanation of images in episode 1
github-actions bot pushed a commit that referenced this pull request Jul 30, 2024
Auto-generated via {sandpaper}
Source  : 5b9f0b0
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-07-30 00:57:38 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 184fd48
Branch  : main
Author  : Carsten Schnober <[email protected]>
Time    : 2024-07-23 09:07:59 +0000
Message : Merge pull request #509 from carpentries-incubator/explain-network-figures-episode-1

Improve explanation of images in episode 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix images on neural networks episode 1
2 participants