Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links to software setup. #503

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Fix links to software setup. #503

merged 1 commit into from
Jul 23, 2024

Conversation

carschno
Copy link
Collaborator

@carschno carschno commented Jul 22, 2024

There seem to be two issues here:

  • The string ``{{ page.root }}` is not resolved, but becomes part of the literal URL in the rendered HTML
  • The anchor is called software-setup, not setup

Fixes #502

Notes for Reviewer

The proposed fix is to remove the {{ page.root }} entirely. This works locally, but I am not entirely certain about potential side effects.

@carschno carschno self-assigned this Jul 22, 2024
@carschno carschno requested a review from svenvanderburg July 22, 2024 14:45
Copy link

github-actions bot commented Jul 22, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/deep-learning-intro/compare/md-outputs..md-outputs-PR-503

The following changes were observed in the rendered markdown documents:

 1-introduction.md | 4 ++--
 md5sum.txt        | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-07-22 14:46:15 +0000

github-actions bot pushed a commit that referenced this pull request Jul 22, 2024
Copy link
Collaborator

@svenvanderburg svenvanderburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't foresee any problems, but I will check once this is deployed to github pages.

@svenvanderburg svenvanderburg merged commit 88e4386 into main Jul 23, 2024
3 checks passed
@svenvanderburg svenvanderburg deleted the fix/setup_link branch July 23, 2024 07:13
github-actions bot pushed a commit that referenced this pull request Jul 23, 2024
Auto-generated via {sandpaper}
Source  : 88e4386
Branch  : main
Author  : Carsten Schnober <[email protected]>
Time    : 2024-07-23 07:13:55 +0000
Message : Fix links to software setup. (#503)
github-actions bot pushed a commit that referenced this pull request Jul 23, 2024
Auto-generated via {sandpaper}
Source  : 958532d
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-07-23 07:14:57 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 88e4386
Branch  : main
Author  : Carsten Schnober <[email protected]>
Time    : 2024-07-23 07:13:55 +0000
Message : Fix links to software setup. (#503)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In the Installing Keras and other dependencies section: it looks like the setup url is broken.
2 participants