Remove call for beta testers. #499
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/carpentries-incubator/deep-learning-intro/compare/md-outputs..md-outputs-PR-499 The following changes were observed in the rendered markdown documents: What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-07-23 07:57:31 +0000 |
| @@ -20,21 +20,6 @@ Learners are expected to have the following knowledge: | |||
|
|
|||
| ::: instructor | |||
There was a problem hiding this comment.
Looks like this opening statement should also be removed? (or needs a closing if you like my comment below)
There was a problem hiding this comment.
I understand that this line now opens the "Breaks and Schedule" div.
| @@ -20,21 +20,6 @@ Learners are expected to have the following knowledge: | |||
|
|
|||
| ::: instructor | |||
|
|
|||
| ## Looking for Beta Testers! | |||
There was a problem hiding this comment.
I would suggest to instead replace this with:
We can help you out with teaching this lesson!
Do you want to teach this lesson? Feel free to reach out to us with any questions that you have. Just open a new issue. We also value any feedback on the lesson!
There was a problem hiding this comment.
That would seem a bit redundant with the "Teaching this lesson?" section in the README. Maybe a link there would be better to keep the information in sync?
There was a problem hiding this comment.
@svenvanderburg How about this?
There was a problem hiding this comment.
Good point! I like your solution :)
Co-authored-by: Sven van der Burg <[email protected]>
| @@ -20,21 +20,6 @@ Learners are expected to have the following knowledge: | |||
|
|
|||
| ::: instructor | |||
|
|
|||
| ## Looking for Beta Testers! | |||
There was a problem hiding this comment.
Good point! I like your solution :)
Auto-generated via {sandpaper}
Source : d66e571
Branch : main
Author : Carsten Schnober <[email protected]>
Time : 2024-07-23 08:01:07 +0000
Message : Remove call for beta testers. (#499)
* Remove call for beta testers.
* Fix language.
Co-authored-by: Sven van der Burg <[email protected]>
* Add teaching block with link to README.
---------
Co-authored-by: Sven van der Burg <[email protected]>
Auto-generated via {sandpaper}
Source : dc0908d
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-07-23 08:01:58 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : d66e571
Branch : main
Author : Carsten Schnober <[email protected]>
Time : 2024-07-23 08:01:07 +0000
Message : Remove call for beta testers. (#499)
* Remove call for beta testers.
* Fix language.
Co-authored-by: Sven van der Burg <[email protected]>
* Add teaching block with link to README.
---------
Co-authored-by: Sven van der Burg <[email protected]>
Fixes #450