Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/minor comments review sarah #496

Merged
merged 8 commits into from
Jul 22, 2024
Merged

Fix/minor comments review sarah #496

merged 8 commits into from
Jul 22, 2024

Conversation

carschno
Copy link
Collaborator

  • Update list of supported browsers
  • Add links to Wikipedia/Glossary
  • Minor language fixes
  • Update software version and installation check

Closes #449

@carschno carschno requested a review from svenvanderburg July 22, 2024 12:07
@carschno carschno linked an issue Jul 22, 2024 that may be closed by this pull request
Fix minor comments from Carpentries Lab review #449
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2024 •
edited
Loading

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/deep-learning-intro/compare/md-outputs..md-outputs-PR-496

The following changes were observed in the rendered markdown documents:

 1-introduction.md         | 37 ++++++++++++++++++++++---------------
 2-keras.md                | 32 +++++++++++++++++---------------
 3-monitor-the-model.md    |  9 +++++----
 4-advanced-layer-types.md |  5 +++--
 6-outlook.md              |  2 +-
 md5sum.txt                | 12 ++++++------
 setup.md                  | 17 +++++++++--------
 7 files changed, 63 insertions(+), 51 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-07-22 12:50:18 +0000

github-actions bot pushed a commit that referenced this pull request Jul 22, 2024
@actions-user
differences for PR #496
fda8c7f
@carschno carschno force-pushed the fix/minor_comments_review_sarah branch from e2e3bae to 387f914 Compare July 22, 2024 12:26
github-actions bot pushed a commit that referenced this pull request Jul 22, 2024
@actions-user
differences for PR #496
657bfff
svenvanderburg
svenvanderburg approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@svenvanderburg svenvanderburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I left a few minor comments.

episodes/1-introduction.Rmd Outdated
@@ -57,15 +57,17 @@ A neural network consists of connected computational units called **neurons**. E
- most of the time, each neuron conducts 3 main operations:
+ take the weighted sum of the inputs where ($w_1, w_2, ... $) indicate weights
+ add an extra constant weight (i.e. a bias term) to this weighted sum
+ apply a non-linear function to the output so far (using a predefined activation function such as the ReLU function)
+ apply a non-linear function to the output so far (using a predefined activation function such as the [ReLU](https://en.wikipedia.org/wiki/Rectifier_(neural_networks)) function)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be changed again with #498 , but approving for now.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, the link is unnecessary now. Merged.

episodes/1-introduction.Rmd Outdated Show resolved Hide resolved
github-actions bot pushed a commit that referenced this pull request Jul 22, 2024
@actions-user
differences for PR #496
2257727
@carschno carschno merged commit 40fe409 into main Jul 22, 2024
3 checks passed
@carschno carschno deleted the fix/minor_comments_review_sarah branch July 22, 2024 12:51
github-actions bot pushed a commit that referenced this pull request Jul 22, 2024
@actions-user
markdown source builds
6b6c891 
Auto-generated via {sandpaper}
Source  : 40fe409
Branch  : main
Author  : Carsten Schnober <[email protected]>
Time    : 2024-07-22 12:51:30 +0000
Message : Merge pull request #496 from carpentries-incubator/fix/minor_comments_review_sarah

Fix/minor comments review sarah
github-actions bot pushed a commit that referenced this pull request Jul 22, 2024
@actions-user
site deploy
2852d22 
Auto-generated via {sandpaper}
Source  : 6b6c891
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-07-22 12:52:29 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 40fe409
Branch  : main
Author  : Carsten Schnober <[email protected]>
Time    : 2024-07-22 12:51:30 +0000
Message : Merge pull request #496 from carpentries-incubator/fix/minor_comments_review_sarah

Fix/minor comments review sarah
github-actions bot pushed a commit that referenced this pull request Jul 23, 2024
@actions-user
markdown source builds
57df29b 
Auto-generated via {sandpaper}
Source  : 40fe409
Branch  : main
Author  : Carsten Schnober <[email protected]>
Time    : 2024-07-22 12:51:30 +0000
Message : Merge pull request #496 from carpentries-incubator/fix/minor_comments_review_sarah

Fix/minor comments review sarah
github-actions bot pushed a commit that referenced this pull request Jul 23, 2024
@actions-user
site deploy
ae55284 
Auto-generated via {sandpaper}
Source  : 57df29b
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-07-23 00:57:12 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 40fe409
Branch  : main
Author  : Carsten Schnober <[email protected]>
Time    : 2024-07-22 12:51:30 +0000
Message : Merge pull request #496 from carpentries-incubator/fix/minor_comments_review_sarah

Fix/minor comments review sarah
github-actions bot pushed a commit that referenced this pull request Jul 23, 2024
@actions-user
site deploy
d36d313 
Auto-generated via {sandpaper}
Source  : 57df29b
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-07-23 00:57:12 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 40fe409
Branch  : main
Author  : Carsten Schnober <[email protected]>
Time    : 2024-07-22 12:51:30 +0000
Message : Merge pull request #496 from carpentries-incubator/fix/minor_comments_review_sarah

Fix/minor comments review sarah
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenvanderburg svenvanderburg svenvanderburg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix minor comments from Carpentries Lab review
2 participants
@carschno @svenvanderburg