-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dollar street dataset #448
Conversation
🆗 Pre-flight checks passed 😃This pull request has been checked and contains no modified workflow files or spoofing. Results of any additional workflows will appear here when they are done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggesting a few minor changes as I read through what you have changed already. It looks very promising @svenvanderburg. Would you like me to jump in and adjust the remaining code/output blocks (e.g. changing model names) and inserting the remaining plots that you have not already updated?
Co-authored-by: Toby Hodges <[email protected]>
Co-authored-by: Toby Hodges <[email protected]>
Co-authored-by: Toby Hodges <[email protected]>
Co-authored-by: Toby Hodges <[email protected]>
Co-authored-by: Toby Hodges <[email protected]>
Co-authored-by: Toby Hodges <[email protected]>
Thanks for your great suggestions @tobyhodges! I really like the part about provenance of the dataset👍 Yes you can pick this up if you want, but keep in mind that adding the images of all the graphs is quite a hassle :) If you don't pick it up I will pick it up in the week of 15th of April. But very much appreciated if you do it! 👍 |
@svenvanderburg I have pushed a few more changes. Please take a look if and when you have time. |
Co-authored-by: Toby Hodges <[email protected]>
@tobyhodges great changes! While doing some more minor changes I realised that the training really takes too long for teaching. I ended up using smaller images (64 x 64 instead of 128 x 128). This speeds up training to a workable duration and reduces overfitting a bit. You can checkout the related changes here: https://github.com/carpentries-incubator/deep-learning-intro/pull/448/files/40b7c7e28174532002751aaa2f6fe4878a2020a5..8a3e077d56c516eb8b7abdc282485b948334dc17 Note that the flow didn't change much, it's just the dimensions of the models and different results. I also updated the setup instructions to instruct learners to download the dataset. I feel like this is ready to go now, can you have a final look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggesting one very minor change but otherwise this is great. Thanks for all your work on it @svenvanderburg.
I think the episode is missing one or two concluding sentences at the very end, summarising what we achieved (and did not achieve) with the models trained here, lessons learned (e.g. about training data and the difficulty of image classification tasks) and perhaps suggesting some next steps the learner could take if they wanted to improve their results. But that can be added in a separate PR.
Co-authored-by: Toby Hodges <[email protected]>
Auto-generated via {sandpaper} Source : a1cb617 Branch : main Author : Sven van der Burg <[email protected]> Time : 2024-04-29 11:08:25 +0000 Message : Use dollar street dataset (#448) * Add notebook for preparing dollar street dataset * Start of lesson using dollar street dataset * Update episodes/4-advanced-layer-types.Rmd Co-authored-by: Toby Hodges <[email protected]> * Update episodes/4-advanced-layer-types.Rmd Co-authored-by: Toby Hodges <[email protected]> * Update episodes/4-advanced-layer-types.Rmd Co-authored-by: Toby Hodges <[email protected]> * Update episodes/4-advanced-layer-types.Rmd Co-authored-by: Toby Hodges <[email protected]> * Update episodes/4-advanced-layer-types.Rmd Co-authored-by: Toby Hodges <[email protected]> * Update episodes/4-advanced-layer-types.Rmd Co-authored-by: Toby Hodges <[email protected]> * minor fixes * update figures * Use 64x64 images * Update setup instructions with dollar street download * Update episodes/4-advanced-layer-types.Rmd Co-authored-by: Toby Hodges <[email protected]> * Update episodes/4-advanced-layer-types.Rmd Co-authored-by: Toby Hodges <[email protected]> --------- Co-authored-by: Toby Hodges <[email protected]> Co-authored-by: Toby Hodges <[email protected]>
Auto-generated via {sandpaper} Source : 24cbca8 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-04-29 11:09:33 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : a1cb617 Branch : main Author : Sven van der Burg <[email protected]> Time : 2024-04-29 11:08:25 +0000 Message : Use dollar street dataset (#448) * Add notebook for preparing dollar street dataset * Start of lesson using dollar street dataset * Update episodes/4-advanced-layer-types.Rmd Co-authored-by: Toby Hodges <[email protected]> * Update episodes/4-advanced-layer-types.Rmd Co-authored-by: Toby Hodges <[email protected]> * Update episodes/4-advanced-layer-types.Rmd Co-authored-by: Toby Hodges <[email protected]> * Update episodes/4-advanced-layer-types.Rmd Co-authored-by: Toby Hodges <[email protected]> * Update episodes/4-advanced-layer-types.Rmd Co-authored-by: Toby Hodges <[email protected]> * Update episodes/4-advanced-layer-types.Rmd Co-authored-by: Toby Hodges <[email protected]> * minor fixes * update figures * Use 64x64 images * Update setup instructions with dollar street download * Update episodes/4-advanced-layer-types.Rmd Co-authored-by: Toby Hodges <[email protected]> * Update episodes/4-advanced-layer-types.Rmd Co-authored-by: Toby Hodges <[email protected]> --------- Co-authored-by: Toby Hodges <[email protected]> Co-authored-by: Toby Hodges <[email protected]>
Fixes #445