Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding aria-label to Dismiss button #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding aria-label to Dismiss button #116

wants to merge 1 commit into from

Conversation

satishreddy84
Copy link

Adding aria-label to the dismiss button to support accessibility.

@lukethacoder
Copy link

Would love to see this simple change merged in for screen readers.

@AbrahemAlhofe
Copy link
Contributor

Would love to see this simple change merged in for screen readers.

I think there are a lot of pull requests we should care about it too, like my pull request 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukethacoder lukethacoder lukethacoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@satishreddy84 @lukethacoder @AbrahemAlhofe