Change dummy queryset qualifier from "all" to "none" #1683
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is, django-filter is not compatible with django-scopes. Django-scopes is an additional guardrail which prevents accidental data exposure. It replaces the default manager of a model with a specialized manager that will refuse queries, unless a scope is active, that is there is a restriction along the critical dimensions are present.
This breaks most usages of the
.all()
queryset. But luckily, many usages that only care about the queryset itself and not the contents can be replaced with.none()
.This pull request replaces the critical all usage with none. Nothing else is changed.
Example exception fixed by this PR: