Skip to content

Fix: Implemented a safety check to stop carla from crashing when using reloadWorld argument with same town #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Implemented a safety check to stop carla from crashing when using reloadWorld argument with same town #1153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,4 @@ results*.txt
*.svg
*.dot
.venv
test.ipynb
10 changes: 9 additions & 1 deletion scenario_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,13 +325,21 @@ def _record_criteria(self, criteria, name):
with open(file_name, 'w', encoding='utf-8') as fp:
json.dump(criteria_dict, fp, sort_keys=False, indent=4)

def _get_town_name(self):
town_name = self.world.get_map().name
town_id = os.path.basename(town_name)[0:6]
return town_id

def _load_and_wait_for_world(self, town, ego_vehicles=None):
"""
Load a new CARLA world and provide data to CarlaDataProvider
"""

if self._args.reloadWorld:
self.world = self.client.load_world(town)
if self._get_town_name() == town[0:6] :
print(f"{town} is already loaded into the simulator.")
else:
self.world = self.client.load_world(town)
else:
# if the world should not be reloaded, wait at least until all ego vehicles are ready
ego_vehicle_found = False
Expand Down