Update DoublyLinkedList.c #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On line no 183, I have changed this --> k < position -1 to this --> k < position because if there are 5 elements in the list and you try to delete the 6th one, k < position -1, because of this condition last element was getting removed even if the position does not exist. I have added one more case in the end
| @@ -180,7 +180,7 @@ void delete(struct DLLNode **head, int position) { | |||
| temp = temp->next; | |||
| k++; | |||
| } | |||
| if(k < position-1){ | |||
| if(k < position){ | |||
There was a problem hiding this comment.
I think @Mishra-Sagar ,
if( k != position) is also valid . What do you say?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On line no 183, I have changed this --> k < position -1 to this --> k < position
because if there are 5 elements in the list and you try to delete the 6th one, k < position -1, because of this condition last element was getting removed even if the position does not exist.
I have added one more case in the end