Error handling for card saves, including WAF rejections #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemelia
force-pushed
the
cs-7576-show-error-when-save-request-blocked-by-waf
branch
from
2c205d9 to
0de7b6f
Compare
lukemelia
changed the title
backspace
approved these changes
Nov 29, 2024
| @@ -579,6 +583,60 @@ module('Integration | operator-mode', function (hooks) { | |||
| assert.dom('[data-test-pet]').includesText('Paper Bad cat!'); | |||
| }); | |||
|
|
|||
| test('a 403 from Web Appliction Firewall is handled gracefully when auto-saving', async function (assert) { | |||
| // TODO: setup virtual network to return WAF 403 when saving | |||
There was a problem hiding this comment.
Is this tracked somewhere? I couldn’t find an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.