Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace some generators with generators from cardano-api and cardano-ledger #1755

Merged
merged 4 commits into from
Jan 3, 2025

Conversation

locallycompact
Copy link
Contributor

@locallycompact locallycompact commented Nov 29, 2024

No description provided.

@locallycompact locallycompact requested a review from a team November 29, 2024 15:56
Copy link

github-actions bot commented Nov 30, 2024

Transaction cost differences

No cost or size differences found

Copy link

github-actions bot commented Nov 30, 2024

Transaction costs

Sizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using arbitrary values and results are not fully deterministic and comparable to previous runs.

Metadata
Generated at 2025-01-03 13:44:00.012879108 UTC
Max. memory units 14000000
Max. CPU units 10000000000
Max. tx size (kB) 16384

Script summary

Name Hash Size (Bytes)
νInitial 00a6ddbc130ab92f5b7cb8d1ccd8d79eca5bfe25f6843c07b62841f0 2667
νCommit 3e5a776bcee213e3dfd15806952a10ac5590e3e97d09d62eb99266b2 690
νHead 5350e9d521552ebfd9e846fd70c3b801f716fc14296134ec0fb71e97 14495
μHead 482c3ce15cde05bc905b915ccfa2546e500be1c5d722389026c37aa3* 5615
νDeposit de09cec5f84eedaf64186cb52ba4ee6e74e6fc368af25b90d457f352 1118
  • The minting policy hash is only usable for comparison. As the script is parameterized, the actual script is unique per head.

Init transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 6165 10.33 3.30 0.53
2 6366 12.21 3.88 0.56
3 6567 14.24 4.52 0.59
5 6971 18.19 5.75 0.65
10 7974 28.50 8.99 0.80
44 14811 98.66 31.09 1.82

Commit transaction costs

This uses ada-only outputs for better comparability.

UTxO Tx size % max Mem % max CPU Min fee ₳
1 561 2.45 1.17 0.20
2 739 3.40 1.74 0.22
3 920 4.39 2.34 0.24
5 1277 6.46 3.61 0.28
10 2181 12.24 7.28 0.40
54 10081 99.20 68.72 1.89

CollectCom transaction costs

Parties UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
1 57 525 25.04 7.27 0.43
2 113 636 33.99 9.79 0.52
3 170 747 43.56 12.53 0.63
4 227 858 52.32 15.01 0.72
5 282 974 56.19 16.34 0.76
6 338 1081 64.27 18.59 0.85
7 394 1192 84.54 23.92 1.06
8 450 1303 91.83 26.07 1.14
9 504 1414 97.90 27.92 1.20

Cost of Increment Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 1830 24.13 8.04 0.48
2 1949 25.48 9.13 0.51
3 2118 27.91 10.63 0.55
5 2401 30.39 12.79 0.59
10 3245 42.27 20.11 0.78
43 8081 99.64 61.12 1.75

Cost of Decrement Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 604 22.44 7.26 0.41
2 730 23.43 8.18 0.43
3 889 25.38 9.42 0.46
5 1381 31.98 12.60 0.56
10 1902 36.93 17.30 0.66
44 6985 98.11 57.14 1.66

Close transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 685 27.03 8.73 0.46
2 835 28.68 9.92 0.49
3 922 32.06 11.57 0.53
5 1224 36.16 14.27 0.60
10 1977 45.58 20.65 0.75
39 6632 99.81 58.85 1.67

Contest transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 686 33.35 10.42 0.53
2 815 35.34 11.70 0.56
3 978 37.54 13.09 0.59
5 1280 41.62 15.74 0.66
10 2081 53.38 22.99 0.84
31 5182 98.44 51.59 1.55

Abort transaction costs

There is some variation due to the random mixture of initial and already committed outputs.

Parties Tx size % max Mem % max CPU Min fee ₳
1 6051 26.25 8.87 0.69
2 6165 34.73 11.73 0.79
3 6242 40.33 13.60 0.85
4 6459 52.96 17.96 0.99
5 6493 57.56 19.41 1.04
6 6749 71.55 24.19 1.20
7 6959 79.12 26.99 1.29
8 7108 91.67 31.21 1.43
9 7071 98.19 33.19 1.49

FanOut transaction costs

Involves spending head output and burning head tokens. Uses ada-only UTXO for better comparability.

Parties UTxO UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
10 0 0 6162 17.82 6.07 0.61
10 1 57 6197 19.99 6.94 0.63
10 5 285 6332 27.98 10.15 0.73
10 10 570 6502 37.61 14.03 0.84
10 40 2279 7524 95.81 37.45 1.53
10 41 2336 7558 97.61 38.18 1.55

End-to-end benchmark results

This page is intended to collect the latest end-to-end benchmark results produced by Hydra's continuous integration (CI) system from the latest master code.

Please note that these results are approximate as they are currently produced from limited cloud VMs and not controlled hardware. Rather than focusing on the absolute results, the emphasis should be on relative results, such as how the timings for a scenario evolve as the code changes.

Generated at 2025-01-03 13:46:17.64293898 UTC

Baseline Scenario

Number of nodes 1
Number of txs 300
Avg. Confirmation Time (ms) 4.826376603
P99 10.989495559999991ms
P95 6.689518550000004ms
P50 4.4346295ms
Number of Invalid txs 0

Three local nodes

Number of nodes 3
Number of txs 900
Avg. Confirmation Time (ms) 24.121034016
P99 119.47999297ms
P95 30.22588829999999ms
P50 20.8596765ms
Number of Invalid txs 0

Copy link

github-actions bot commented Nov 30, 2024

Test Results

  5 files  ±0  165 suites  ±0   31m 34s ⏱️ -29s
563 tests ±0  557 ✅ ±0  6 💤 ±0  0 ❌ ±0 
565 runs  ±0  559 ✅ ±0  6 💤 ±0  0 ❌ ±0 

Results for commit 68e0a17. ± Comparison against base commit a529e19.

♻️ This comment has been updated with latest results.

@locallycompact locallycompact force-pushed the lc/remove-gen-address branch 2 times, most recently from 8ba9064 to d2dfd1b Compare December 7, 2024 11:27
@locallycompact locallycompact force-pushed the lc/remove-gen-address branch 3 times, most recently from 1a9a18a to 23c25eb Compare December 8, 2024 10:39
@locallycompact locallycompact changed the title Use genAddress from cardano-ledger-byron-test Replace some generators with generators from cardano-api and cardano-ledger Dec 8, 2024
@locallycompact locallycompact force-pushed the lc/remove-gen-address branch 3 times, most recently from d5fbf57 to 939c293 Compare January 3, 2025 10:13
@locallycompact locallycompact requested review from a team and removed request for a team January 3, 2025 10:30
@noonio
Copy link
Contributor

noonio commented Jan 3, 2025

This seems good; but can you say a bit about why we're switching to hedgehog here? Can you elaborate on what some differences might be/what instances are used for that/why we'd prefer it to arbitrary?

Copy link
Contributor

@noonio noonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; requesting some commentary on what hedgehog is adding here.

@locallycompact
Copy link
Contributor Author

This seems good; but can you say a bit about why we're switching to hedgehog here? Can you elaborate on what some differences might be/what instances are used for that/why we'd prefer it to arbitrary?

We have not switched to hedgehog yet, we are reusing upstream hedgehog generators in QuickCheck.

@locallycompact locallycompact added this pull request to the merge queue Jan 3, 2025
Merged via the queue into master with commit 7b36819 Jan 3, 2025
27 checks passed
@locallycompact locallycompact deleted the lc/remove-gen-address branch January 3, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants