Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tx json instances #1422

Merged
merged 2 commits into from
May 9, 2024
Merged

Fix Tx json instances #1422

merged 2 commits into from
May 9, 2024

Conversation

ffakenz
Copy link
Contributor

@ffakenz ffakenz commented May 9, 2024

Fixes #1421

This PR also includes a minor fix over the PeerHandshakeFailure type to be aligned with the api spec:

  • We converted the version number from an int to a natural.

  • CHANGELOG updated or not needed
  • Documentation updated or not needed
  • Haddocks updated or not needed
  • No new TODOs introduced or explained herafter

Copy link

github-actions bot commented May 9, 2024

Transactions Costs

Sizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using arbitrary values and results are not fully deterministic and comparable to previous runs.

Metadata
Generated at 2024-05-09 16:08:35.270002119 UTC
Max. memory units 14000000
Max. CPU units 10000000000
Max. tx size (kB) 16384

Script summary

Name Hash Size (Bytes)
νInitial bccf2a430c016bc960fbf31b02694011cd399d20da8882aac9d33611 4110
νCommit 56b0f0b597150e619c76bed60683f3b1e42d7bc0685ed951b882bfc5 1975
νHead 86bff95ba20e9d1d1b34899a56d86bbacc9fed999260b27dcc92d128 9351
μHead 88f533cf67cd0fc93d7d9ccf0a8b1d69ffd1208a825efbebbc1d36ba* 4213
  • The minting policy hash is only usable for comparison. As the script is parameterized, the actual script is unique per Head.

Cost of Init Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 4799 8.89 3.40 0.46
2 4996 10.82 4.14 0.49
3 5197 12.55 4.80 0.51
5 5600 16.43 6.29 0.57
10 6604 26.16 10.02 0.72
48 14244 99.87 38.32 1.86

Cost of Commit Transaction

This is using ada-only outputs for better comparability.

UTxO Tx size % max Mem % max CPU Min fee ₳
1 559 10.24 4.04 0.29
2 748 13.88 5.64 0.34
3 933 17.66 7.29 0.39
5 1310 25.66 10.74 0.49
10 2249 48.19 20.30 0.78
19 3924 97.83 40.79 1.41

Cost of CollectCom Transaction

Parties UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
1 57 544 16.52 6.53 0.35
2 114 654 26.98 10.75 0.47
3 170 764 39.26 15.77 0.61
4 227 874 50.19 20.37 0.74
5 282 984 68.99 28.00 0.95
6 339 1095 88.27 35.92 1.17

Cost of Close Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 619 8.29 4.62 0.28
2 787 9.41 6.00 0.30
3 933 10.11 7.07 0.32
5 1278 12.38 9.86 0.38
10 1487 15.34 8.69 0.40
50 8242 51.03 63.96 1.39

Cost of Contest Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 654 8.69 4.77 0.28
2 757 9.34 5.78 0.30
3 943 10.56 7.22 0.33
5 1319 12.30 9.71 0.38
10 1926 15.81 14.97 0.47
50 8025 51.32 63.48 1.38

Cost of Abort Transaction

Some variation because of random mixture of still initial and already committed outputs.

Parties Tx size % max Mem % max CPU Min fee ₳
1 4674 17.05 7.38 0.55
2 4828 28.90 12.66 0.69
3 4974 42.13 18.52 0.84
4 5232 60.67 26.83 1.06
5 5165 71.41 31.29 1.18
6 5384 98.08 43.23 1.49

Cost of FanOut Transaction

Involves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.

Parties UTxO UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
5 0 0 4627 7.64 3.19 0.44
5 1 57 4661 9.21 4.08 0.46
5 5 286 4799 13.61 6.84 0.52
5 10 568 4965 18.95 10.22 0.60
5 20 1138 5306 30.69 17.44 0.76
5 30 1708 5647 42.43 24.67 0.92
5 40 2277 5987 53.96 31.81 1.08
5 50 2846 6325 65.29 38.86 1.24
5 79 4498 7310 98.79 59.60 1.70

End-To-End Benchmark Results

This page is intended to collect the latest end-to-end benchmarks results produced by Hydra's Continuous Integration system from the latest master code.

Please take those results with a grain of salt as they are currently produced from very limited cloud VMs and not controlled hardware. Instead of focusing on the absolute results, the emphasis should be on relative results, eg. how the timings for a scenario evolve as the code changes.

Generated at 2024-05-09 16:10:48.137289219 UTC

Baseline Scenario

Number of nodes 3
Number of txs 9000
Avg. Confirmation Time (ms) 23.903676874
P99 117.58485471ms
P95 35.21972169999999ms
P50 20.7222455ms
Number of Invalid txs 0

Baseline Scenario

Number of nodes 1
Number of txs 3000
Avg. Confirmation Time (ms) 4.255557058
P99 8.345068879999992ms
P95 5.355689499999999ms
P50 4.022636ms
Number of Invalid txs 0

@ffakenz ffakenz force-pushed the ensemble/fix-tx-type branch from 527156a to e0b2f13 Compare May 9, 2024 10:52
@ffakenz ffakenz requested a review from a team May 9, 2024 10:52
Copy link

github-actions bot commented May 9, 2024

Test Results

426 tests  ±0   416 ✅ ±0   13m 47s ⏱️ - 1m 11s
138 suites ±0    10 💤 ±0 
  2 files   ±0     0 ❌ ±0 

Results for commit d664784. ± Comparison against base commit f081958.

♻️ This comment has been updated with latest results.

@ffakenz ffakenz force-pushed the ensemble/fix-tx-type branch 4 times, most recently from 738131e to 83bb961 Compare May 9, 2024 16:04
@ffakenz ffakenz changed the title Fix the tx type Fix Tx json instance May 9, 2024
@ffakenz ffakenz changed the title Fix Tx json instance Fix Tx json instances May 9, 2024
@ffakenz ffakenz force-pushed the ensemble/fix-tx-type branch from 83bb961 to d664784 Compare May 9, 2024 16:05
@ffakenz ffakenz merged commit 6d75c29 into master May 9, 2024
20 checks passed
@ffakenz ffakenz deleted the ensemble/fix-tx-type branch May 9, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instructions for submitting tx to head wrong
2 participants