Add note on MockChain behavior

Thel MockChain behaves quite different than the real cardano chain interfaced through a cardano-node (see FIXME)
cardano-scaling · Feb 19, 2024 · e1ebdbe · e1ebdbe
1 parent a2096b2
commit e1ebdbe
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/hydra-node/test/Hydra/Model/MockChain.hs b/hydra-node/test/Hydra/Model/MockChain.hs
@@ -31,7 +31,7 @@ import Hydra.BehaviorSpec (
   SimulatedChainNetwork (..),
  )
 import Hydra.Cardano.Api.Pretty (renderTxWithUTxO)
-import Hydra.Chain (Chain (..), initHistory)
+import Hydra.Chain (Chain (..), PostTxError (..), initHistory)
 import Hydra.Chain.Direct.Fixture (testNetworkId)
 import Hydra.Chain.Direct.Handlers (
   ChainSyncHandler (..),
@@ -149,15 +149,15 @@ mockChainAndNetwork tr seedKeys commits = do
               Left err ->
                 throwSTM . userError . toString $
                   unlines
-                    [ "Invalid tx submitted"
+                    [ "MockChain: Invalid tx submitted"
                     , "Tx: " <> toText (renderTxWithUTxO utxo tx)
                     , "Error: " <> show err
                     ]
               Right report
                 | any isLeft report ->
                     throwSTM . userError . toString $
                       unlines
-                        [ "Invalid tx submitted"
+                        [ "MockChain: Invalid tx submitted"
                         , "Tx: " <> toText (renderTxWithUTxO utxo tx)
                         , "Error: " <> show (lefts . toList $ report)
                         ]
@@ -239,6 +239,10 @@ mockChainAndNetwork tr seedKeys commits = do
       Nothing ->
         pure ()
 
+  -- FIXME: This should actually work more like a chain fork / switch to longer
+  -- chain. That is, the ledger switches to the longer chain state right away
+  -- and we issue rollback and forwards to synchronize clients. However,
+  -- submission will already validate against the new ledger state.
   rollbackAndForward nodes chain numberOfBlocks = do
     doRollBackward nodes chain numberOfBlocks
     replicateM_ (fromIntegral numberOfBlocks) $