Restore usage of persistenceIncremental in Hydra.Network.Reliability

We do not want to update this module (yet) with a different means for persistence.

hydra-node/src/Hydra/Network/Reliability.hs

@@ -189,7 +189,7 @@ mkMessagePersistence ::
   PersistenceIncremental (Heartbeat msg) m ->
   Persistence (Vector Int) m ->
   MessagePersistence m msg
-mkMessagePersistence numberOfParties persistenceIncremental ackPersistence =
+mkMessagePersistence numberOfParties msgPersistence ackPersistence =
   MessagePersistence
     { loadAcks = do
         macks <- load ackPersistence
@@ -199,13 +199,11 @@ mkMessagePersistence numberOfParties persistenceIncremental ackPersistence =
     , saveAcks = \acks -> do
         save ackPersistence acks
     , loadMessages = do
-        loadAll persistenceIncremental
+        loadAll msgPersistence
     , appendMessage = \msg -> do
-        append persistenceIncremental msg
+        append msgPersistence msg
     }
 
--- TODO(Elaine): this can probably be replaced with new persistence
-
 -- | Middleware function to handle message counters tracking and resending logic.
 --
 -- '''NOTE''': There is some "abstraction leak" here, because the `withReliability`

hydra-node/src/Hydra/Node/Network.hs

@@ -150,7 +150,6 @@ configureMessagePersistence ::
   m (MessagePersistence m msg)
 configureMessagePersistence tracer persistenceDir numberOfParties = do
   msgPersistence <- createPersistenceIncremental $ storedMessagesFile persistenceDir
-  -- NOTE(Elaine): after deliberation, new persistence should be fine for network messages
   ackPersistence@Persistence{load} <- createPersistence $ acksFile persistenceDir
   mAcks <- load
   ackPersistence' <- case fmap (\acks -> length acks == numberOfParties) mAcks of