Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation - Centralized Telescope: Parameters #103
base: main
Are you sure you want to change the base?
Documentation - Centralized Telescope: Parameters #103
Changes from 12 commits
c8b93a2
73e2046
7d7b885
929b501
95571f3
54d7d89
e7a4b10
66bd086
e7a719e
17e9829
84c09f7
7ee6d27
e582322
d813cc3
5d3f7bf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cases here don't really correspond to small, intermediate and high cases that you outlined in
strategy.md
. The intermediate case there implies the number of repetitions r > 1, but cases 2 and 3 in this file can in principle set r = 1. So, cases 2 and 3 here really cover both intermediate and high cases but in different ways, depending on how u and lam_rel^(2) compare. Suggest changing wording.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@curiecrypt Just precise here that we use a different comparison for the intermediary and high cases instead of lambda^2 <= u < lambda^3 and u >= lambda^3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the documentation should provide a bridging content between the code and the theory. I tried to create an intermediate-level text for someone who looks at the code first. Matching structure with code is more convenient to understand the content of the paper, I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the biggest issue right now that prevent me from LGTMing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As in the "Cases", I wanted to adopt a similar structure as the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. But this would abort only in debug mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similarly, why this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are assumptions in the paper from theorem 13/14 for the soundness and completeness bounds to be valid. We added them in code as we noticed that Case 1/2/3 and Small/Intermediary/High did not necessarily respect these. @curiecrypt must have added them here for exhaustivity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly.